https://bugzilla.redhat.com/show_bug.cgi?id=1278964 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > IMO should be debian-distro-info... Current name is too common. distro-info matches what upstream is using and IMHO the chance for collisions is not that high, so lets just keep it as is. Full review done: Good: ==== - rpmlint checks return: [hans@shalem ~]$ rpmlint rpmbuild/RPMS/x86_64/distro-info-* rpmbuild/SRPMS/distro-info-0.14-1.fc23.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - license (ISC) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: ======== - Please add a comment (# foo) above: "%make_install VENDOR=ubuntu" why you use VENDOR=ubuntu here - license text not in %files as %license, please add: %license debian/copyright to %files for all (sub)packages. Note normally you would only add a %license line to %files for the main pkg, but since the different sub-pkgs do not interdepend here (and there is no main pkg), you need to add it to all sub-pkgs. - Does not own all directories that it creates: Does not own the %{perl_vendorlib}/Debian dir If you can create a -2 srpm fixing these 3 issues, then we should be good to go wrt this pkg. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review