https://bugzilla.redhat.com/show_bug.cgi?id=1263821 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Full review done: Good: ==== - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+ and MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: ======== - rpmlint checks return: dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/security-master.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/metas/boring.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/DEFAULT.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/mentors.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/ppa.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/ssh-upload.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/ubuntu.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/metas/ubuntu.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/ftp-master.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/metas/debomatic.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/profiles/ftp-eu.json dput-ng.noarch: W: conffile-without-noreplace-flag /etc/dput.d/metas/debian.json These warnings can be silenced by replacing %config with %config(noreplace), the question i, is this the right thing todo or should we just ignore the warnings? %config(noreplace) means that if the user modifies these files that any (modified) files in the rpm will get installed as etc/dput.d/foo/bar.json.rpmnew, and the user version will be kept. Ideally the system version of these files would live under /usr/share/dput.d/foo/bar.json, and dput would first check for a user version under /etc/dput.d/ and if that not exists fallback to the system defaults from /usr/share/dput.d I'm fine with keeping this as is, adding the (noreplace), or moving the files enitrely to /usr/share (if user modification is not expected / not desirable). Your call. - license text not marked as %license, the LICENSE file should be a seperate line in %files starting with %license, rather then being part of %doc If you can create a 2 srpm fixing these 2 issues (note as said for the first issue, not taking any action is an acceptable solution), then we should be good to go wrt this pkg. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review