[Bug 1287846] Review Request: python-lib389 - python module to access the 389 Directory Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1287846



--- Comment #29 from mreynolds@xxxxxxxxxx ---
(In reply to Antonio Trande from comment #27)
> - Why have you added these lines?


I was following the checklist:

Must: If you build for a single python runtime you must add %python_provide
python-$module so that the current default python is provided from the
unversioned python package. 

Above this comment on the same page it gives an example:

=============================================
%package -n python2-%{srcname}
Summary:        %{sum}
%{?python_provide:%python_provide python2-%{srcname}}

%description -n python2-%{srcname}
An python module which provides a convenient example.
============================================


> 
> >%package -n python2-lib389
> >Summary: %{sum}
> >%{?python_provide:%python_provide python2-lib389}
> >
> >%description -n python2-lib389
> >%{desc}
> 
> Kee only this one:
> %{?python_provide:%python_provide python2-lib389}

This works fine, and I've updated/uploaded the spec file.  Thanks

> 
> - I tried to run tests in this way
> 
> %check
> export PYTHONPATH=$RPM_BUILD_ROOT%{python2_sitelib}
> pytest -v -t build/lib/lib389/tests
> 
> but just now I suspect that they're made to work differently instead:
> 
> http://www.port389.org/docs/389ds/FAQ/upstream-test-framework.html#basic-
> setup-and-testing

The "tests" we have written are designed to be run against a running 389
Directory Server.  This doesn't seem like something that can be tested/run
during rpm building.  So basically there is nothing to test, or should I say we
don't have any tests that can be run during rpm packaging.

UPDATE

As for the epel7 build failure that was just reported, I have just
updated/uploaded the spec file to include python-setuptools.  This was not
needed for my mock builds, but it also does not cause any harm by adding it(no
downloads, etc)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]