https://bugzilla.redhat.com/show_bug.cgi?id=1289193 --- Comment #5 from MartinKG <mgansser@xxxxxxxx> --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/htmlcxx.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/htmlcxx-0.85-2.fc23.src.rpm %changelog * Mon Dec 07 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.85-2 - removed BR gcc-c++ - replaced %%RPM_BUILD_ROOT by %%{buildroot} - removed Buildroot tag - use %%{?_smp_mflags} in make - corrected license tag - removed unrecognized configure options and added correct one - added isa to requires tag - removed all '*.la' files - Mark license files as %%license where available (In reply to Antonio Trande from comment #2) > - Remove gcc-c++ as BR done > > - Package uses either %{buildroot} or $RPM_BUILD_ROOT done > > - Why a BuildRoot? Do you need this package in EPEL5? done > > - htmlcxx-0.85/html/tree.h is licensed with GPLv2+ license > Code is released with LGPLv2 license. done > "The uri parsing code is a derivative work of > Apache web server uri parsing routines. Check > www.apache.org/licenses/LICENSE-2.0 or the ASF-2.0 file in the > distribution for details." > > Please, fix the License tag. done > > - I dont see any '--without-static' option. Try with > > %configure --disable-static --enable-shared done > Maybe you don't need 'chrpath' anymore. htmlcxx doesn't compile w/o chrpath > > - Requires: %{name} = %{version}-%{release} is wrong > Use Requires: %{name}%{?_isa} = %{version}-%{release} done > > - Remove all '*.la' files done > > - Please, fix all rpmlint warnings checking: htmlcxx-0.85-2.fc24.x86_64.rpm htmlcxx-devel-0.85-2.fc24.x86_64.rpm htmlcxx-debuginfo-0.85-2.fc24.x86_64.rpm htmlcxx-0.85-2.fc24.src.rpm htmlcxx.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml htmlcxx.x86_64: W: shared-lib-calls-exit /usr/lib64/libcss_parser.so.0.0.0 exit@GLIBC_2.2.5 htmlcxx.x86_64: W: no-manual-page-for-binary htmlcxx htmlcxx-devel.x86_64: W: only-non-binary-in-usr-lib htmlcxx-devel.x86_64: W: no-documentation htmlcxx-devel.x86_64: E: incorrect-fsf-address /usr/include/htmlcxx/html/tree.h htmlcxx-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/htmlcxx-0.85/html/tree.h htmlcxx.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml 4 packages and 0 specfiles checked; 2 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review