https://bugzilla.redhat.com/show_bug.cgi?id=1270364 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from gil cattaneo <puntogil@xxxxxxxxx> --- NON blocking issues: [!]: Packages should try to preserve timestamps of original installed files. install -m 644 bfd/libbfd.a %{buildroot}%{_libdir} install -m 644 libiberty/libiberty.a %{buildroot}%{_libdir} install -m 644 include/libiberty.h %{buildroot}%{_prefix}/include install -m 644 opcodes/libopcodes.a %{buildroot}%{_libdir} Please, use install -pm ... [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _gnu %{nil}, %define enable_shared 0 Please, fix before import. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review