https://bugzilla.redhat.com/show_bug.cgi?id=1288643 --- Comment #2 from Dmitry Mikhirev <mikhirev@xxxxxxxxx> --- (In reply to Igor Gnatenko from comment #1) > -> Requires: %{name} = %{version}-%{release} > should be: %{name}%{?_isa} = %{version}-%{release} Thnk you! Fixed. > > -> install -m 755 build/libdlib.so.%{version}.* %{buildroot}%{_libdir} > isnt this managed by cmake? No. > If you will still use install you should keep timestamps by > using '-p'. cmake does not preserve timestamps when installing files. Should we really take care of this when installing manually? > Description for py2/py3 subpkgs not correlates with python stuff, please > adjust. The same for -devel subpackage Fixed. > I dont see that python subpackages requires main package (please check it) > and if it requires - no need to duplicate license. They don't require it. Python modules are linked statically and don't use the shared library. Probably this is incorrect, but I couldn't find an easy way to fix this, dynamic linking would require heavy rewriting of build scripts. New URLs: Spec: http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/dlib.git/plain/dlib.spec?id=350ddd8c6cc0eb57720e565e83ecf75b2cdd59ff SRPM: https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00145335-dlib/dlib-18.18-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review