https://bugzilla.redhat.com/show_bug.cgi?id=1288643 --- Comment #1 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- Unformal quick review because NEEDSPONSOR: -> Requires: %{name} = %{version}-%{release} should be: %{name}%{?_isa} = %{version}-%{release} -> install -m 755 build/libdlib.so.%{version}.* %{buildroot}%{_libdir} isnt this managed by cmake? If not I would prefer to patch cmake instead of monkey-copying. If you will still use install you should keep timestamps by using '-p'. -> %{python2_sitearch}/dlib/ -> %{python2_sitearch}/dlib-*.egg-info/ %{python2_sitearch}/%{name}* Description for py2/py3 subpkgs not correlates with python stuff, please adjust. The same for -devel subpackage I dont see that python subpackages requires main package (please check it) and if it requires - no need to duplicate license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review