https://bugzilla.redhat.com/show_bug.cgi?id=1270355 --- Comment #5 from Jonathan Dieter <jdieter@xxxxxxxxx> --- Ok, this looks like it's overall in great shape. I do have a few questions, most of them a bit nit-picky. 1- Nothing owns /usr/x86_64-nacl, and I'm pretty sure we should. 2- All of the binaries are hardlinked from /usr/x86_64-nacl/* to /usr/bin/x86_64-nacl-*. According to the guidelines at https://fedoraproject.org/wiki/Packaging_Cross_Compiling_Toolchains, these should be symlinks. In extremely rare (possibly non-existent) situations (like having /usr/bin on a separate partition than /usr), hardlinks will cause a problem. Having said that, other cross-compiling toolchains in Fedora are using hardlinks instead of symlinks. I asked on the packaging mailing list, and it seems symlinks are preferable, but not enough as to make this a blocker. If you're up for converting the hardlinks to symlinks, that would be great, but if you feel it's just make-work that's not worth the effort, we can let this go. 3- This has ExclusiveArch: x86_64. I'm sure there are good reasons for this, but, according to https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch (which may look familiar to you, Tom, as I believe you wrote it 😉), ExclusiveArch is highly discouraged. There's already a comment in the spec requesting that it not be built on arm, but, at least according to https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures, it looks like this ExclusiveArch should really be converted to multiple ExcludeArch's with explanations as to why it can't build for each arch. If this toolchain is designed to only work under x86_64, I'd really love that to be made very explicitly clear in the spec, but if it can theoretically built and used in other arches, I think we have to go through the official process listed in the guidelines cited in the previous paragraph. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review