https://bugzilla.redhat.com/show_bug.cgi?id=970393 --- Comment #21 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> --- [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/foomatic/db/source, /usr/share/foomatic/db, /usr/share/foomatic/db/source/driver, /usr/share/cups/model, /usr/share/foomatic, /usr/share/foomatic/db/source/printer, /usr/share/foo2qpdl, /usr/share/foomatic/db/source/opt, /usr/share/cups For some of those, perhaps we want Requires: foomatic-db? /usr/share/foo2qpdl seems like a simple omission. Do we want to require cups-filesystem for the latter? Also, now I'm looking at the Requires:.... should it require /bin/rm not /usr/bin/rm? [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define foo2zjs_ver 20151111 That can be changed, can't it? Finally (although not strictly a review comment) does any active user have one of the printers which need firmware loaded, and can we get that working automatically too? -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review