[Bug 1258405] Review Request: python-colorclass - Yet another ANSI color text library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1258405



--- Comment #5 from Julien Enselme <jujens@xxxxxxxxx> ---
- You should use the license (fetching it is just the fist step). Add `%license
%{SOURCE1}` to all packages
- Your changelog is not correct: you have two entries with the same version
(1.2.0-1). Each time you add an entry, you must increase the Release version
number and use it in the changelog. This number can only be one again if the
version of the software changes. I also suggest that you put an empty line
between each entry for readability.

> However the colorclass package has no unitary test.

It's a should item so it is not a big deal if you cannot launch them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]