https://bugzilla.redhat.com/show_bug.cgi?id=1258405 --- Comment #4 from René Ribaud <rene.ribaud@xxxxxxx> --- Hello Julien, Thanks for reviewing my previous package. I have updated a new package (same location) with almost all the fixed mentioned implemented. If you could have a new look that will be great. The exception is the test part. I tried to investigate and implement your suggestion : "You should add `py.test-%{python2-version} --cov-report term-missing --cov colorclass tests` and `py.test-%{python3-version} --cov-report term-missing --cov colorclass tests` in %check and add python-pytest and python3-pytest as BR." FYI, here are some little corrections needed to implement it : %{python2-version} is %{python2_version} %{python3-version} is %{python3_version} Buildrequires are : Python2 : pytest (don't know why this module does not follow naming rules) python-pytest-cov (Pytest plugin for coverage reporting) Python3 : python3-pytest python3-pytest (Pytest plugin for coverage reporting) However the colorclass package has no unitary test. So I finally decided to keed the %check part empty. If you think this is not the correct approach please let me know. Best regards. René -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review