[Bug 1258405] Review Request: python-colorclass - Yet another ANSI color text library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1258405



--- Comment #6 from René Ribaud <rene.ribaud@xxxxxxx> ---
Hello Julien,

> - You should use the license (fetching it is just the fist step). Add `%license %{SOURCE1}` to all packages

Doing that is not working, %{SOURCE1} is expanded to the full path and then
rpmbuild does not find it.

RPM build errors:
    File not found:
/home/uggla/rpmbuild/BUILDROOT/python-colorclass-1.2.0-1.fc22.x86_64/home/uggla/rpmbuild/SOURCES/LICENSE


So I have copied the LICENSE file in the %prep state and incorporated it into
the %file section using %license statement.
I think this is the expected behavior from package perspective.

>Your changelog is not correct

Changelog corrected. Strange that rpmlint did not find this kind of pitfall.
Anyway that should be good now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]