https://bugzilla.redhat.com/show_bug.cgi?id=1226719 --- Comment #2 from Marcus Karlsson <mk@xxxxxxxxxx> --- Thank you for doing the review. I have updated the spec file and I believe that the issues should be resolved now. Updated spec URL: http://www.acc.umu.se/~mk/fedora/menulibre/20150720T1815/menulibre.spec Updated SRPM URL: http://www.acc.umu.se/~mk/fedora/menulibre/20150720T1815/menulibre-2.0.6-1.fc22.src.rpm Changes: - License file COPYING has been marked as %license and removed from %doc. - Package now owns the %{datadir}/menulibre directory. - BR python3 has been removed. - The %clean section has been removed. - Hashbang lines are removed from files in %{python3_sitelib}/menulibre{,_lib}, resolving the rpmlint issues. These files are not supposed to be invoked directly, so opting to remove the hashbang instead of marking the files as executable. rpmlint: rpmlint menulibre.spec menulibre-2.0.6-1.fc22.noarch.rpm menulibre-2.0.6-1.fc22.src.rpm menulibre 3 packages and 1 specfiles checked; 0 errors, 0 warnings. diff -u 20150531T2115/menulibre.spec 20150720T1815/menulibre.spec --- 20150531T2115/menulibre.spec 2015-05-31 23:17:15.983984688 +0200 +++ 20150720T1815/menulibre.spec 2015-07-20 20:17:41.864882650 +0200 @@ -12,7 +12,6 @@ BuildRequires: desktop-file-utils BuildRequires: gettext BuildRequires: intltool -BuildRequires: python3 BuildRequires: python3-devel BuildRequires: python3-distutils-extra Requires: gnome-menus @@ -35,6 +34,14 @@ %install %{__python3} setup.py install --root=%{buildroot} + +# Remove hashbang line from non-executable library files +for lib in %{buildroot}%{python3_sitelib}/menulibre{,_lib}/*.py; do + sed '1{\@^#!/usr/bin/python3@d}' $lib > $lib.new && + touch -r $lib $lib.new && + mv $lib.new $lib +done + desktop-file-validate %{buildroot}/%{_datadir}/applications/menulibre.desktop %find_lang %{name} @@ -50,11 +57,9 @@ %posttrans gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : -%clean -rm -rf %{buildroot} - %files -f %{name}.lang -%doc AUTHORS COPYING NEWS PKG-INFO README +%doc AUTHORS NEWS PKG-INFO README +%license COPYING %{_bindir}/%{name} %{_datadir}/applications/menulibre.desktop %{_datadir}/icons/hicolor/16x16/apps/menulibre.svg @@ -63,7 +68,7 @@ %{_datadir}/icons/hicolor/48x48/apps/menulibre.svg %{_datadir}/icons/hicolor/64x64/apps/menulibre.svg %{_datadir}/icons/hicolor/scalable/apps/menulibre.svg -%{_datadir}/menulibre/ui/MenulibreWindow.ui +%{_datadir}/menulibre/ %{_datadir}/pixmaps/menulibre.png %{_mandir}/man1/menulibre.1.gz %{python3_sitelib}/menulibre -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review