[Bug 1244014] Review Request: python-ddt - Data-Driven/Decorated Tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1244014



--- Comment #4 from Carl George <carl.george@xxxxxxxxxxxxx> ---
> Have you tried running %build and %install without creating  a separate py3k directory? This package doesn't use 2to3 so this should work juts as well.

I have not tried it that way.  I just did it the same way I saw several other
module packages do it (pip, setuptools, six, click).  The only documentation I
could find about this says the macro should be used when the same source is
used for both python2 and python3 [1], which is the case here.

> You can use %global _docdir_fmt %{name} to use a common license and documentation directories.

I'm not following what the point of this would be.  I thought the current
project goal was to separate license files from documentation [2]?

> Summary or %description should say what this package is in more basic term (e.g. a library which provides a testing framework).

I thought that was clear in the summary, but I am not a wordsmith, so I'm open
to more detailed suggestions here.  I just copied the current summary and
description from the setup.py and README.md files.  Maybe the long_description
in the setup.py would be more appropriate for the RPM description?

> long_description='A library to multiply test cases',


[1]: https://fedoraproject.org/wiki/Python3.4GuidlinesDraft#Macros
[2]:
https://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image#Summary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]