https://bugzilla.redhat.com/show_bug.cgi?id=1226719 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orion@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx --- Comment #1 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Need to own %{datadir}/menulibre, change: %{_datadir}/menulibre/ui/MenulibreWindow.ui to %{_datadir}/menulibre/ - BR python3 is redundant and not needed - Remove %clean - Fix rpmlint errors ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)". Detailed output of licensecheck in /export/home/orion/redhat/1226719-menulibre/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/menulibre, /usr/share/menulibre/ui [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/menulibre, /usr/share/menulibre/ui [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in menulibre [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: menulibre-2.0.6-1.fc23.noarch.rpm menulibre-2.0.6-1.fc23.src.rpm menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/helpers.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenulibreXdg.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenuEditor.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/__init__.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/menulibreconfig.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/__init__.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/util.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/XmlMenuElementTree.py 0644L /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenulibreApplication.py 0644L /usr/bin/python3 2 packages and 0 specfiles checked; 9 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenulibreApplication.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/XmlMenuElementTree.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/helpers.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/util.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenulibreXdg.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/__init__.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/MenuEditor.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre/__init__.py 644 /usr/bin/python3 menulibre.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/menulibre_lib/menulibreconfig.py 644 /usr/bin/python3 1 packages and 0 specfiles checked; 9 errors, 1 warnings. Requires -------- menulibre (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 gnome-menus gtk3 python(abi) python3-psutil Provides -------- menulibre: application() application(menulibre.desktop) menulibre Source checksums ---------------- https://launchpad.net/menulibre/2.0/2.0.6/+download/menulibre-2.0.6.tar.gz : CHECKSUM(SHA256) this package : 6ee70b11e35c60dc2ee73b96ee494927f708264549bf4432f1cdb43e13ca26c4 CHECKSUM(SHA256) upstream package : 6ee70b11e35c60dc2ee73b96ee494927f708264549bf4432f1cdb43e13ca26c4 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/bin/fedora-review -b 1226719 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review