https://bugzilla.redhat.com/show_bug.cgi?id=1234210 --- Comment #4 from Globe Trotter <itsme_410@xxxxxxxxx> --- Sorry, I am new to this. > for f in setup.py stapler.egg-info/requires.txt ; do > sed -i 's/pypdf == 1.12/pypdf == .*/g' $f > done > > can be changed to > > sed -i 's/pypdf == 1.12/pypdf == .*/g' setup.py stapler.egg-info/requires.txt > > Nothing serious, just easier to read. > Actually You could just 'rm -rf stapler.egg-info', it would be recreated > during installation. So, instead of the sed, replace with rm -rf stapler.egg-info (I tried this, and it "worked".) > > Please install the license file using %license > [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. I am sorry but how do I add the file? > > Add /usr/lib/python2.7/site-packages/staplelib to %files. I did this but I now get warnings, eg: warning: File listed twice: /usr/lib/python2.7/site-packages/staplelib/__init__.py .... > > pdf-stapler.noarch: W: incoherent-version-in-changelog tat.maitra@xxxxxxxxx > ['0.3.0-1.fc23', '0.3.0-1'] Not sure I understand this point. > Also, change %{__python} to %{__python2} (I'm assuming that python3 is not > supported) > [https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes]. At this point, however, pdf-stapler is moving to python3, in which case I will also move it to python3. (I don't quite see the point of supporting both..) Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review