https://bugzilla.redhat.com/show_bug.cgi?id=1234210 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Globe Trotter from comment #2) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > No need to run sed in a loop, just pass all the file names to sed at once. > I am not sure how to do this, please advise if this is a serious issue. for f in setup.py stapler.egg-info/requires.txt ; do sed -i 's/pypdf == 1.12/pypdf == .*/g' $f done can be changed to sed -i 's/pypdf == 1.12/pypdf == .*/g' setup.py stapler.egg-info/requires.txt Nothing serious, just easier to read. Actually You could just 'rm -rf stapler.egg-info', it would be recreated during installation. > > Also, are you sure that you want to encode pypdf version in the file? This > > package will have to be updated whenever the pypdf package is updated to a > > new version. Why not remove the pypdf version (s/pypdf == .*/pypdf/) ? > > pyPdf is dead. The only update will be to PyPDF2. That is also my package > which is also under review. So, at this point, this is not particularly an > issue? OK. > Spec URL: https://streaming.stat.iastate.edu/~stat580/fedora/pdf-stapler.spec > SRPM URL: > https://streaming.stat.iastate.edu/~stat580/fedora/pdf-stapler-0.3.0-1.fc22. > src.rpm Please install the license file using %license [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. Add /usr/lib/python2.7/site-packages/staplelib to %files. pdf-stapler.noarch: W: incoherent-version-in-changelog tat.maitra@xxxxxxxxx ['0.3.0-1.fc23', '0.3.0-1'] Also, change %{__python} to %{__python2} (I'm assuming that python3 is not supported) [https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes]. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review