https://bugzilla.redhat.com/show_bug.cgi?id=1234210 --- Comment #2 from Globe Trotter <itsme_410@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > %description should be wrapped to 72 columns. But please change > the text to something which describes what the package does (history > is not relevant). I have included a short description but also left a bit of the history as well as the dependencyon PyPDF2. I think this will be helpful for future packagers. > > Summary should start with a capital letter. done > Remove %defattr. done > There are some stale comments, remove them too. I presume that these means the commented-out codes? Done, but for commented out Requires. > No need to run sed in a loop, just pass all the file names to sed at once. I am not sure how to do this, please advise if this is a serious issue. > Also, are you sure that you want to encode pypdf version in the file? This > package will have to be updated whenever the pypdf package is updated to a > new version. Why not remove the pypdf version (s/pypdf == .*/pypdf/) ? pyPdf is dead. The only update will be to PyPDF2. That is also my package which is also under review. So, at this point, this is not particularly an issue? New source rpms and spec files at: Spec URL: https://streaming.stat.iastate.edu/~stat580/fedora/pdf-stapler.spec SRPM URL: https://streaming.stat.iastate.edu/~stat580/fedora/pdf-stapler-0.3.0-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review