https://bugzilla.redhat.com/show_bug.cgi?id=1234210 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- %description should be wrapped to 72 columns. But please change the text to something which describes what the package does (history is not relevant). Summary should start with a capital letter. Remove %defattr. There are some stale comments, remove them too. No need to run sed in a loop, just pass all the file names to sed at once. Also, are you sure that you want to encode pypdf version in the file? This package will have to be updated whenever the pypdf package is updated to a new version. Why not remove the pypdf version (s/pypdf == .*/pypdf/) ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review