https://bugzilla.redhat.com/show_bug.cgi?id=1234210 --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Globe Trotter from comment #4) > > Please install the license file using %license > > [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. > > I am sorry but how do I add the file? > > > > > Add /usr/lib/python2.7/site-packages/staplelib to %files. Use something like that for %files: %files %{_bindir}/%{name} /usr/lib/python2.7/site-packages/stapler-%{version}-py2.7.egg-info %{python2_sitelib}/staplelib %license LICENSE (This will include the directory .../staplelib and its contents.) (It will also install the file LICENSE into %{_pkgdocdir}.) > I did this but I now get warnings, eg: > > warning: File listed twice: > /usr/lib/python2.7/site-packages/staplelib/__init__.py > > .... > > > > > > pdf-stapler.noarch: W: incoherent-version-in-changelog tat.maitra@xxxxxxxxx > > ['0.3.0-1.fc23', '0.3.0-1'] > > Not sure I understand this point. You are missing version information in the changelog. The line look should look something like this: * Fri May 22 2015 Name Lastname <stat.maitra@xxxxxxxxx> - 0.3.0-1 > > Also, change %{__python} to %{__python2} (I'm assuming that python3 is not > > supported) > > [https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes]. > > At this point, however, pdf-stapler is moving to python3, in which case I > will also move it to python3. (I don't quite see the point of supporting > both..) That's great. The distribution as a whole is trying to move to python3 as much as possible [https://fedoraproject.org/wiki/Changes/Python_3_as_Default]. So if you can can switch pdf-stapler to use python3 that would be great. But independently of the switch, whatever version is used by the application, it is supposed to be clearly marked. So if it is using python2, then use %{__python2} (which is /usr/bin/python2), otherwise use %{__python3} (which is /usr/bin/python3). This is done in preparation for possibly switching /usr/bin/python to point at python3 instead of python2 at some point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review