https://bugzilla.redhat.com/show_bug.cgi?id=1203749 --- Comment #10 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Dave Love from comment #9) > Thanks for taking it. > > I made makefile use DESTDIR in the usual way (not as above) by patching it. > Is this covered by policy somewhere? It seems a waste of effort > to me, and I've made other things build in similar ways. We are doing same thing essentially. I prefer to use only one DESTDIR. > > What's the problem with having -O3 in CFLAGS? I assume it's known to be > beneficial, and > orion told me it was OK to use extra flags in that case. http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > > I don't understand why BOOST_{INC,LIB}_DIR, DEBUG, and INSTALL need setting. Boost must be set in Make.config file; better if set manually in the SPEC file in case of changes in future. Debugging is considered by Make but **explicitly** not required during building process. INSTALL='install -p' is ended up there by chance. I think it's useless. > > Using %licence gives: > > Processing files: dssp-2.2.1-3.el6.x86_64 > error: File must begin with "/": Boost > error: File must begin with "/": LICENSE_1_0.txt %license works only in Fedora (for now). https://fedorahosted.org/fpc/ticket/411 > %clean > rm -rf $RPM_BUILD_ROOT http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review