https://bugzilla.redhat.com/show_bug.cgi?id=1203749 --- Comment #11 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Dave, you should also pass distribution-wide linker flags to linker command: %build ... echo "LDOPTS=%{__global_ldflags}" >>make.config make %{?_smp_mflags} Doing rm -rf %{buildroot} is not an error (certainly not review-blocking) if you wish to maintain a single spec across all EL and Fedora branches, but you need to use %license where available, so try the following: %files %{!?_licensedir:%global license %%doc} %license LICENSE_1_0.txt %doc changelog README.txt Since the package contains just one binary, please use %{_bindir}/mkdssp instead of %_bindir/* And, similarly, %{_mandir}/man1/mkdssp.1* Finally, I wouldn't insist on patching DESTDIR into the Makefile and simply used: make install DEST_DIR=%{buildroot}%{_prefix} in %install section. Sending a patch to support setting PREFIX and DESTDIR independently upstream is of course recommended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review