https://bugzilla.redhat.com/show_bug.cgi?id=1183193 --- Comment #15 from Taylor Braun-Jones <taylor@xxxxxxxxxxxxxxx> --- Thanks, Rich. I had played with the idea of using EIGENSPARSE=ON originally, but converted back to using SUITESPARSE=ON and forgot to add back the CXSPARSE_INCLUDE_DIR. I never had a problem finding BLAS, but adding the BLAS_LIBRARIES flag is a good idea anyway. While were on the topic, what is the preferred approach for the Fedora package? (1) Use SUITESPARSE for sparse metrix support. Increases the package dependencies but results in a ceres-solver package with a more permissive license (BSD) (2) Use EIGENSPARSE for sparse metrix support. Results in fewer package dependencies (because Eigen is already a hard dependency), but then ceres-solver becomes LGPL licensed. Chris - Thanks for the review. 1, 2 fixed. 3, 4 - For the cmake files, it would be helpful if the CMake packaging documentation[1] covered more details like this. I wasn't sure what was preferred in Fedora and was trying copy what I'd seen in some other Fedora packages. For now, I've just removed the mv line so that the .cmake files stay at the original upstream installation path %{_datadir}/Ceres. New spec and SRPM here: http://files.braun-jones.org/ceres-solver.spec http://files.braun-jones.org/ceres-solver-1.10.0-3.el7.centos.src.rpm [1] http://fedoraproject.org/wiki/Packaging:Cmake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review