https://bugzilla.redhat.com/show_bug.cgi?id=1183193 Rich Mattes <richmattes@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #16 from Rich Mattes <richmattes@xxxxxxxxx> --- Have you been building in mock? If you're building the package locally and happen to have a compatible BLAS package (e.g. OpenBLAS) installed, CMake will find and use that even if it's not what you intended.. The only way to be sure your dependencies and package configuration are correct is to build the package in mock (either locally or via koji scratch builds). Personally, I'd probably lean towards (1) unless there's a good reason to use eigen instead (e.g. it's significantly faster.) The suitesparse package isn't too big, and since the dependencies are taken care of by our package manager, there's no extra work to be done for consumers of the ceres-solver package. CMake configuration script location isn't mandated by Fedora, but if you want CMake to find the scripts you need to put them somewhere on CMake's search path which is documented at http://www.cmake.org/cmake/help/v3.0/command/find_package.html. In this case, CMake would have found the package either way: <name> is case-independent in the applicable "/usr/share/<name>*/" CMake search path. One last thing: you might consider adding a BuildRequires on metis-devel to enable the optional METIS support. metis is available in fedora and epel, I'm not sure what extra functionality it adds and whether it's worth it to include it. That being said, the package as it stands looks good, and this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review