[Bug 1183193] Review Request: ceres-solver - A non-linear least squares minimizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1183193



--- Comment #14 from Christopher Meng <i@xxxxxxxx> ---
1. Drop rm -rf $RPM_BUILD_ROOT

2. Drop 

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

3. %{_datadir}/%{name}
%{_datadir}/%{name}/*.cmake

No, use this:

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*.cmake

(And these cmake files should be put under cmake module dir, but anyway I don't
know who uses ceres now)

4. 
# Make the subdirectory in /usr/share match the name of this package
mv $RPM_BUILD_ROOT%{_datadir}/{Ceres,%{name}}

Well, is it accepted by upstream? Note that your change will only take effect
on Fedora but not other distros at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]