https://bugzilla.redhat.com/show_bug.cgi?id=1195573 --- Comment #7 from Ben Boeckel <mathstuf@xxxxxxxxx> --- (In reply to Petr Šabata from comment #6) > 1. I would use the release URL instead of just pointing to the commit (which > could be something entirely different and nobody will notice). For example > https://github.com/s-aska/%{name}/archive/%{version}.tar.gz should work just > fine. The tarball filename will be just the version plus extension but that > doesn't really matter. https://fedoraproject.org/wiki/Packaging:SourceURL#Github > 2. Missing buildtime dependencies: perl, perl(CPAN::Meta), > perl(CPAN::Meta::Prereqs), perl(File::Basename), perl(File::Spec), > perl(strict), perl(utf8), perl(warnings) Hmm. Is there a way to detect these automatically? I think perl(WebService::Dropbox) also necessary. Or is that just a runtime dep? I'm not all that well-versed in Perl stuff. > 3. Use perl macros for the perl lib paths in %files; changing > %{_datadir}/perl5/App/dropboxapi.pm to %{perl_vendorlib}/* would be fine. Ah, I used rpmdev-newspec -t perl for this. Will do. > 4. A more useful %description would be nice. This isn't necessary. I'll put something together. > 5. You shouldn't need to define prefix, I suppose? rpmdev-newspec's doing; I'll remove it if that's more modern. > 6. Perhaps the project Github page would work better for the URL. Probably. Will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review