https://bugzilla.redhat.com/show_bug.cgi?id=985051 --- Comment #8 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- > http://fedoraproject.org/wiki/PackagingDrafts/AutoConf That's just an old "draft" - an opinion piece - not a final guideline approved by the FPC. Also notice the comment someone has left at the top. ;-) Fact is, regenerating Autotools files is not trivial for all projects. At best, they would fail to rebuild and you would get error messages. At worst, they are broken silently (and e.g. you lose macros or inserted/appended modifications which result in building the source code differently and possibly in a wrong way). > Upstream's Makefile now supports DESTDIR, which let me cut out %make_install. %make_install is one of the macros that's _recommended_. It differs from %makeinstall (no '_' in there!). See: rpm -E %make_install https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Currently, it would only save some typing compared with your full invocation of "make install ...". Good to know, but that's all. > make %{?_smp_mflags} > > %install > make install DESTDIR=%{buildroot} PREFIX=%{_prefix} MANDIR=%{buildroot}%{_mandir}/man1 Noticing the extra %buildroot here in the MANDIR definition, I've had a look at "Makefile*". It's a mix between a manually written Makefile and one that uses Autotools. It contains some questionable definitions for PREFIX, BINDIR, MANDIR and DESTDIR, which should not be done like that. After running the configure script, it should not be necessary anymore to override PREFIX or MANDIR anymore when running "make". Typically, "configure" defines those paths already and substitutes them in the generated Makefiles. See "rpm -E %configure" for the options passed to the configure script. It would be good to use what "configure" determines, so there are no competing and potentially conflicting places where paths (or other values) are defined. Autotools even generate install paths based on the values it determines (e.g. $prefix, $bindir, $mandir). > %build > %configure This contains a check for SQLite 3, and indeed ./src/svn.c contains conditional code that uses SQLite. It's a bit fragile, because it doesn't error out if SQLite 3 is not found. If you want to add BuildRequires for it, you may want to add a safety check that verifies that SQLite 3 is found and built with. Else build with --with-sqlite3=no to disable that feature explicitly. > %check > make check Any comment on what I asked about at the bottom of comment 5? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review