https://bugzilla.redhat.com/show_bug.cgi?id=985051 steven.merrill@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(steven.merrill@gm | |ail.com) | --- Comment #7 from steven.merrill@xxxxxxxxx --- Spec URL: https://raw.githubusercontent.com/smerrill/vcprompt-spec/master/SPECS/vcprompt.spec SRPM URL: https://raw.githubusercontent.com/smerrill/vcprompt-spec/master/SRPMS/vcprompt-1.2.1-1.fc21.src.rpm Michael, thanks for the ping on this. I have updated to v1.2.1, and I think I've incorporated all the feedback. Upstream's Makefile now supports DESTDIR, which let me cut out %make_install. The full diff in the specs since last time is here: http://fpaste.org/174040/22125836/ Now rpmlint -i only has two complaints: $ rpmlint -i SPECS/* RPMS/*/* SRPMS/* SPECS/vcprompt.spec: W: invalid-url Source0: https://bitbucket.org/gward/vcprompt/downloads/vcprompt-1.2.1.tar.gz HTTP Error 403: Forbidden The value should be a valid, public HTTP, HTTPS, or FTP URL. vcprompt.src: W: invalid-url Source0: https://bitbucket.org/gward/vcprompt/downloads/vcprompt-1.2.1.tar.gz HTTP Error 403: Forbidden The value should be a valid, public HTTP, HTTPS, or FTP URL. 3 packages and 1 specfiles checked; 0 errors, 2 warnings. These two warnings are happening because BitBucket redirects requests for their tarball downloads to an S3 URL that is only valid for a short time. It is preferable to use the BitBucket downloads for two reasons: 1) The tarballs now have vcprompt in their names, which was requested earlier in this thread. 2) The downloads from BitBucket come with a configure script so that autoconf does not have to be run. (I read that autoconf use was discouraged in http://fedoraproject.org/wiki/PackagingDrafts/AutoConf.) Let me know what you think! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review