https://bugzilla.redhat.com/show_bug.cgi?id=1195573 --- Comment #6 from Petr Šabata <psabata@xxxxxxxxxx> --- 1. I would use the release URL instead of just pointing to the commit (which could be something entirely different and nobody will notice). For example https://github.com/s-aska/%{name}/archive/%{version}.tar.gz should work just fine. The tarball filename will be just the version plus extension but that doesn't really matter. 2. Missing buildtime dependencies: perl, perl(CPAN::Meta), perl(CPAN::Meta::Prereqs), perl(File::Basename), perl(File::Spec), perl(strict), perl(utf8), perl(warnings) 3. Use perl macros for the perl lib paths in %files; changing %{_datadir}/perl5/App/dropboxapi.pm to %{perl_vendorlib}/* would be fine. 4. A more useful %description would be nice. This isn't necessary. 5. You shouldn't need to define prefix, I suppose? 6. Perhaps the project Github page would work better for the URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review