https://bugzilla.redhat.com/show_bug.cgi?id=1189611 --- Comment #2 from Pavol Babinčák <pbabinca@xxxxxxxxxx> --- (In reply to Mathieu Bridon from comment #1) > [x]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > => You could use the %license tag instead of %doc for the LICENSE file. > > I won't block the review on this though, you can just change it when > you import the package. ;) Fixed as suggested. > > [!]: Packages should try to preserve timestamps of original installed files. > > => Please use "install -p" to install the files Fixed as suggested. > > [!] You're installing the README.md and LICENSE files twice: > - once in %install > - once by using the %doc macro on the file in the build dir > > Just drop the one from %install. Fixed as suggested. > [x]: Requires correct, justified where necessary. > > => As we just discussed, curl is already in the minimal buildroot (it's a > dependency of rpm) but wget isn't, so for its intended purpose if > would > be better to have fepdkg-minimal depend on curl. > > That's certainly not a blocker for this review, though. Will be fixed in next upstream release. Updated spec URL: https://pbabinca.fedorapeople.org/fedpkg-minimal/fedpkg-minimal.spec Updated SRPM URL: https://pbabinca.fedorapeople.org/fedpkg-minimal/fedpkg-minimal-1.0.0-2.fc22.src.rpm Previously submitted spec and SRPM can be found here: https://pbabinca.fedorapeople.org/fedpkg-minimal/previous-2015-02-05/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review