https://bugzilla.redhat.com/show_bug.cgi?id=1189611 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- --- fedpkg-minimal.spec.old 2015-02-05 15:07:43.000000000 +0100 +++ fedpkg-minimal.spec 2015-02-06 18:45:59.000000000 +0100 @@ -1,6 +1,6 @@ Name: fedpkg-minimal Version: 1.0.0 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Script to allow fedpkg fetch to work Group: Applications/System @@ -25,16 +25,21 @@ %install install -d %{buildroot}%{_bindir} -install -m 755 bin/fedpkg %{buildroot}%{_bindir}/fedpkg -install -d %{buildroot}%{_docdir}/%{name} -install README.md LICENSE %{buildroot}%{_docdir}/%{name} +install -pm 755 bin/fedpkg %{buildroot}%{_bindir}/fedpkg %files -%doc README.md LICENSE +%doc README.md +%license LICENSE %{_bindir}/fedpkg %changelog +* Fri Feb 06 2015 Pavol Babincak <pbabinca@xxxxxxxxxx> - 1.0.0-2 +- use %%license tag instead of %%doc for the LICENSE file (rhbz#1189611) +- preserve timestamp of original installed files (rhbz#1189611) +- drop installation README.md and LICENSE from %%install section to install it + only once from %%doc and %%license macro (rhbz#1189611) + * Wed Feb 04 2015 Pavol Babincak <pbabinca@xxxxxxxxxx> - 1.0.0-1 - Initial release made from http://koji.fedoraproject.org/koji/packageinfo?packageID=17475 ----- That fixes all the issues I had with the original packaging, so this is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review