https://bugzilla.redhat.com/show_bug.cgi?id=1189611 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bochecha@xxxxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |bochecha@xxxxxxxxxxxxxxxxx --- Comment #1 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- Summary ======= [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. => You could use the %license tag instead of %doc for the LICENSE file. I won't block the review on this though, you can just change it when you import the package. ;) [!]: Packages should try to preserve timestamps of original installed files. => Please use "install -p" to install the files [!] You're installing the README.md and LICENSE files twice: - once in %install - once by using the %doc macro on the file in the build dir Just drop the one from %install. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed MUST items ---------- Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. => This package conflicts with fedpkg (/usr/bin/fedpkg). However, this is by design (this new package is supposed to be used in Koji buildroots instead of fedpkg, to limit dependencies), and it has the appropriate explicit Conflicts So this is not a problem. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. => As we just discussed, curl is already in the minimal buildroot (it's a dependency of rpm) but wget isn't, so for its intended purpose if would be better to have fepdkg-minimal depend on curl. That's certainly not a blocker for this review, though. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. => You could use the %license tag instead of %doc for the LICENSE file. I won't block the review on this though, you can just change it when you import the package. ;) [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [-]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. SHOULD items ------------ Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. => Please use "install -p" to install the files [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. EXTRA items ----------- Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fedpkg-minimal-1.0.0-1.fc22.noarch.rpm fedpkg-minimal-1.0.0-1.fc22.src.rpm fedpkg-minimal.noarch: W: no-manual-page-for-binary fedpkg 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- fedpkg-minimal (rpmlib, GLIBC filtered): /bin/bash wget Provides -------- fedpkg-minimal: fedpkg-minimal Source checksums ---------------- http://fedorahosted.org/releases/f/e/fedpkg-minimal/fedpkg-minimal-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 60cea58845205c0a921796a59708821e6304f0bf722a90cb256e50fd804730fa CHECKSUM(SHA256) upstream package : 60cea58845205c0a921796a59708821e6304f0bf722a90cb256e50fd804730fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review