https://bugzilla.redhat.com/show_bug.cgi?id=1173159 --- Comment #24 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #23) > Issues: > ======= > - Packages have proper BuildRequires/Requires on jpackage-utils I think they have. There's BR:java-devel, and R:java-headless,jpackage-utils, which seems to agree with https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires. > - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) > Note: No javadoc subpackage present > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation It's optional. I'd like to skip it for now, since the package is complicated enough anyway. > - Javadoc documentation files are generated and included in -javadoc > subpackage > Note: No javadoc subpackage present > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 574330880 bytes in 12918 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Freaking %doc macro. Fixed. > - libsbml-sharp needs to Requires: mono-core Done. > [!]: Package must own all directories that it creates. > Note: No known owner of /usr/lib64/libsbml > - java-libsbml needs to own %{_libdir}/libsbml Done. > Use %{_monodir} instead of %{_prefix}/lib/mono Done. > [!]: Requires correct, justified where necessary. > see libsbml-sharp note above Ack. > [?]: Package is not known to require an ExcludeArch tag. > note - it does but is marked as such -- this is fine Upstream has acknowledged the issue, but the fix might not be easy. > [!]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 290048000 bytes in /usr/share ruby- > SBML-5.11.0-6.fc21.x86_64.rpm:289546240 Should be fixed now. > libsbml-devel.x86_64: E: incorrect-fsf-address > /usr/include/sbml/packages/render/sbml/ListOfCurveElements.h I'll ping upstram. > ruby-SBML.x86_64: W: dangling-relative-symlink > /usr/share/doc/libsbml/README-ruby.txt src/bindings/ruby/README.txt Yikes, fixed. > libsbml.src:344: W: macro-in-comment %{name} > libsbml.src:350: W: macro-in-comment %{name} Fixed. > libsbml.src:391: E: hardcoded-library-path in %{_prefix}/lib/mono/libsbmlcsP/ > 12 packages and 0 specfiles checked; 30 errors, 17 warnings. I think it's fine. Spec URL: http://in.waw.pl/~zbyszek/fedora/libsbml.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/libsbml-5.11.0-8.fc22.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8810346 (build, but I hope it'll be fine) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review