https://bugzilla.redhat.com/show_bug.cgi?id=1187337 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Some suggestions: 1) Drop the sil prefix. This font does not look to be published on http://scripts.sil.org website so "sil" as a foundry cannot be used. 2) As fonts do get updates without getting their metadata updated. I suggest always to use maximum for versioning like if font provides version number then use it. Also, use the date on which you downloaded source. So consider this as a post-release snapshot package as given in https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages If you look at http://openfontlibrary.org/en/font/bretan page, you can clearly see last updated date given as well as history also shows same zip archive name is used in past. So, your release tag can be either Release: 1.20150122%{?dist} or today's date as you downloaded source today Release: 1.20150203%{?dist} But, considering all these facts I will say for now use "1.20150122" as updated date is specified on website. If it was not there we should use current date. 3) fontconfig file should say "sans-serif" and not "serif" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review