https://bugzilla.redhat.com/show_bug.cgi?id=1186389 --- Comment #5 from Matěj Cepl <mcepl@xxxxxxxxxx> --- (In reply to Toshio Ernie Kuratomi from comment #4) > * man page is a warning but up to you if you want to add one. Personally > I'd see if the main python-mako packager wants to add one. I think that > Debian/Ubuntu has one so they could possibly copy that (or generate it if > that's all that Debian is doing). See bug 1186877 > * Invalid source is a problem. mentioned in previous comment that they seem > to have moved to: > https://pypi.python.org/packages/source/M/Mako/Mako-%{version}.tar.gz Fixed (already in 1.0.1 for python-mako) > * License tag for the javascript seems outdated, no longer under the GPL. I > do see BSD license references though. So probably needs to be updated to: > # The documentation contains javascript for search which are licensed > BSD and MIT > License: (MIT and Python) and (BSD and GPLv2) fixed > * Need to change from unversioned python macros to versioned macros. Like > this: Do I have to? This package will not be used outside of EPEL (I guess), so why should we use non-EPEL names just so that we have to define them? > * mako-render needs to be renamed to be parallel installable. Since we > don't currently need to worry about python3 here, either of these of these > would be fine: > - mako-render-1.0 > - mako-render-v1.0 done > Judgement calls: > * Package naming: I'd name this python-mako1.0 with a dot to separate the > components of the version number done http://mcepl.fedorapeople.org/tmp/python-mako1.0.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=8755878 (SRPM https://kojipkgs.fedoraproject.org//work/tasks/5879/8755879/python-mako1.0-1.0.1-2.el6.src.rpm) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review