https://bugzilla.redhat.com/show_bug.cgi?id=1186389 --- Comment #4 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- * rpmlint: python-mako10.src: W: spelling-error Summary(en_US) Mako -> Mao, Mayo, Macho python-mako10.src: W: spelling-error %description -l en_US Mako -> Mao, Mayo, Macho python-mako10.src: W: spelling-error %description -l en_US Mako's -> Mao's, Mayo's, Macho's python-mako10.src: W: spelling-error %description -l en_US componentized -> component python-mako10.src: W: invalid-url Source0: http://www.makotemplates.org/downloads/Mako-1.0.0.tar.gz HTTP Error 404: Not Found python-mako10.noarch: W: spelling-error Summary(en_US) Mako -> Mao, Mayo, Macho python-mako10.noarch: W: spelling-error %description -l en_US Mako -> Mao, Mayo, Macho python-mako10.noarch: W: spelling-error %description -l en_US Mako's -> Mao's, Mayo's, Macho's python-mako10.noarch: W: spelling-error %description -l en_US componentized -> component python-mako10.noarch: W: no-manual-page-for-binary mako-render python-mako10-doc.noarch: W: spelling-error %description -l en_US Mako -> Mao, Mayo, Macho python-mako10-doc.noarch: W: spelling-error %description -l en_US Mako's -> Mao's, Mayo's, Macho's python-mako10-doc.noarch: W: spelling-error %description -l en_US componentized -> component python-mako10.spec: W: invalid-url Source0: http://www.makotemplates.org/downloads/Mako-1.0.0.tar.gz HTTP Error 404: Not Found 3 packages and 2 specfiles checked; 0 errors, 14 warnings. * Spelling errors are all fine as they're all legal to use in this contect. * man page is a warning but up to you if you want to add one. Personally I'd see if the main python-mako packager wants to add one. I think that Debian/Ubuntu has one so they could possibly copy that (or generate it if that's all that Debian is doing). * Invalid source is a problem. mentioned in previous comment that they seem to have moved to: https://pypi.python.org/packages/source/M/Mako/Mako-%{version}.tar.gz Good: * spec filename matches package name * LICENSE file is included * Spec file is legible * Source matches upstream but see invalid source_url note * Package builds in koji * No localized files provided so no handling needed * Not an elf library so no special handling needed * No bundled libraries * Package is not relocatable * Package owns all directories it creates * Files are not listed twice * Package does not own files or dirs of other packages * Permissions set appropriately * macros used consistently * Package contains code * API Docs split off into separate package * No %doc documentation is used at runtime * Not a GUI app so no special handling * All filenames are valid utf-8 Needs fixing: * The invalid source_url from rpmlint * License tag for the javascript seems outdated, no longer under the GPL. I do see BSD license references though. So probably needs to be updated to: # The documentation contains javascript for search which are licensed BSD and MIT License: (MIT and Python) and (BSD and GPLv2) * Need to change from unversioned python macros to versioned macros. Like this: At the top: %if 0%{?rhel} && 0%{?rhel} <= 6 %{!?__python2: %global __python2 /usr/bin/python2} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif In the spec file: * s/__python/__python2/g * s/python_sitelib/python2_sitelib/g * mako-render needs to be renamed to be parallel installable. Since we don't currently need to worry about python3 here, either of these of these would be fine: - mako-render-1.0 - mako-render-v1.0 Judgement calls: * Package naming: I'd name this python-mako1.0 with a dot to separate the components of the version number -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review