[Bug 1186389] Review Request: python-mako10 - Mako template library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1186389

Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.badger@xxxxxxxxx



--- Comment #3 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> ---
Things I noticed right away (Will do a formal review too):

* Name would be better as python-mako1.0  Using the dotless version is the old
way of doing things but since it's unclear (is that for mako version 1.0 or
mako version 10?) using dots is preferred for new packages.
* Download location doesn't work: I think mako must have switched to using pypi
dor tarball hosting at some point and the main mako package hasn't adjusted (it
should make that change as well)
* Latest version is 1.0.1:
https://pypi.python.org/packages/source/M/Mako/Mako-1.0.1.tar.gz
* The filter is not needed because there won't be any .so's in a noarch python
package.
* The mako-render program will need to be renamed so that it doesn't conflict
with the non forward-compat mako-render.  The rules about how to construct that
name changed recently so I'll have to look it up when I do the full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]