https://bugzilla.redhat.com/show_bug.cgi?id=1182261 --- Comment #15 from Sinny Kumari <ksinny@xxxxxxxxx> --- Updated spec file and also ran basic checks on generated packages. Updated spec and rpms are: SPEC url - https://github.com/sinnykumari/libabigail-package/raw/master/spec/libabigail.spec SRPM url - https://github.com/sinnykumari/libabigail-package/raw/master/srpm/libabigail-1.0-0.2.20150114git63c81f0.fc21.src.rpm Koji Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=8708846 (In reply to Parag AN(पराग) from comment #9) > Few more fixes required for above updated package. > > 1) When you prepare updated package its a good practice to do koji scratch > build and if its a successful build then check rpmlint output for all > generated rpm files. Or you can use fedora-review tool on your own updated > package. Yes, rpmlint ran on generated package > => You need to fix the changelog version-release to > 1.0-0.1.git.20150114git63c81f0 Fixed > => Then the wrong-file-end-of-line-encoding warning can be fixed by adding > BuildRequires: dos2unix > and at the end of %install > dos2unix doc/manuals/html/_static/jquery.js Added dos2unix > 3) As per new guidelines > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text , > you need to use %license macro for license file instead of %doc > %license COPYING-LGPLV3 Fixed > 4) Follow the texinfo guidelines > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo > > You have missing Requires lines and need to use preun (not postun) Using preun instead of postun. Not adding Requires(post): info Requires(preun): info because this dependency should be handled by yum. > 5) I had a look at source archive and it contains approximately 2.9MB of > .git directory which we don't need. So change the source generation step like > > tar -cvzf %%{name}-%%{version}.tar.gz %%{name}-%%{version} --exclude .git > > and generate new tarball, use it and submit new package for further review. Thank you for telling about it. I really didn't notice it. Fixed. > 6) Everytime you update the spec file, increase the release number tag (so > next will be "0.2.%{checkout}%{?dist}" and add corresponding changes > information in %changelog Updated Release number tag and %changelog information (In reply to Richard Shaw from comment #12) > (In reply to Parag AN(पराग) from comment #9) > > => You need to fix the changelog version-release to > > 1.0-0.1.git.20150114git63c81f0 > > The first git is redundant, just use: > %global checkout %{date}git%{git_revision} Fixed > Probably easier to use "git archvie..." at this point. Something like: > > # This tarball was constructed from pulling the source code of > # libabigail from its Git repository by doing: > # git clone git://sourceware.org/git/libabigail.git > # pushd libabigail > # git archive --prefix %%{name}-%%{version}/ -o > %%{name}-%%{version}.tar.gz %%{git_revision} Yes, using it to generate archive and it works absolutely fine :) Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review