[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1182261

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #16 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) Sinny, you are still not following correct %changelog guidelines. Please
read http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs page. I
don't see since last release what you have changed.

2) Currently mock is failing for the package you submitted as the newer
python-sphinx change has not yet published. The last rawhide published was on
23rd Jan. So, we need to wait till next rawhide is available that will add new
package python-sphinx-latex.

3) I don't think info gets pulled automatically by yum. I removed info package
from the system and tried to install locally built libabigail package and can
see info package is not installed automatically.
So, add those requires in -doc subpackage only. 

4) One more think I found. Generally I have not seen people specifying full
subpackage names where the name starts with the main package name. I don't
think you need to follow the subpackage names like "-n <pkgname>" where all
subpackages start with the main package name. For example for devel subpackage,
you can just write as

%package devel
%description devel
%files devel

See
http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch10s04.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]