https://bugzilla.redhat.com/show_bug.cgi?id=1182261 --- Comment #14 from Parag AN(पराग) <panemade@xxxxxxxxx> --- (In reply to Richard Shaw from comment #12) > (In reply to Parag AN(पराग) from comment #9) > > => You need to fix the changelog version-release to > > 1.0-0.1.git.20150114git63c81f0 > > The first git is redundant, just use: > %global checkout %{date}git%{git_revision} > You are right. My eyes missed that. > > > 5) I had a look at source archive and it contains approximately 2.9MB of > > .git directory which we don't need. So change the source generation step like > > > > tar -cvzf %%{name}-%%{version}.tar.gz %%{name}-%%{version} --exclude .git > > > > and generate new tarball, use it and submit new package for further review. > > Probably easier to use "git archvie..." at this point. Something like: > > # This tarball was constructed from pulling the source code of > # libabigail from its Git repository by doing: > # git clone git://sourceware.org/git/libabigail.git > # pushd libabigail > # git archive --prefix %%{name}-%%{version}/ -o > %%{name}-%%{version}.tar.gz %%{git_revision} Not tested but looks this can also work fine. (In reply to Sinny Kumari from comment #13) > Hi, > > Thank you for your feedback. I am making changes into spec file according to > your feedback. Have one question though (mentioned in inline comment) > (In reply to Parag AN(पराग) from comment #9) > > Few more fixes required for above updated package. > > > 6) Everytime you update the spec file, increase the release number tag (so > > next will be "0.2.%{checkout}%{?dist}" and add corresponding changes > > information in %changelog > > Yes, I am aware of updating release number when any modification is done in > spec file. But, currently this package is under review and no non-scratch > build has been done so far. So, is it really needed now? Asking it because I > couldn't find answer to it in Fedora wiki. > Yes you do need to update release number. Many new people asks same question but we need to track how the package got updated since its initial submission. This also helps other people to track how this package is reviewed and approved. I generally don't ask people if its a minor update but in your case there are many changes. Just go through already done package reviews in bugzilla and you will find people did update release number everytime they submitted new changes. You may want to check reviews that got progressed since its submission -> http://fedoraproject.org/PackageReviewStatus/NEEDSPONSOR.html or http://fedoraproject.org/PackageReviewStatus/REVIEW.html Also, this is needed in case when new update fails to build/work we can go to previous changes and find the issues in new update. I too can't find any reference for this in fedora wiki. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review