[Bug 1172414] Review Request: ltp - Linux Test Project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1172414



--- Comment #2 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> ---
Well,

* Documentation
  - At least please add COPYING as %license
  - Also, please consider to add some files to %doc, such
    as README.

* Licensing issue
  - See above

* Debuginfo issue
  - See above

* rpmlint
  - Well, while I ignore "missing-call-to-setgroups-before-setuid"
    rpmlint issue (because these files are for testing such
    syscalls), now:

  * Lots of "non-standard-executable-perm 0775L" rpmlints
    - It should be okay with 0755 (as owner/group is root:root)

  * Some "script-without-shebang" rpmlints
    - As these does not have shebang (and at least some of files
      look like just a text file), these need not have executable
      permission
      (or is this intentional?)

  * Some "spurious-executable-perm" error on testcases/bin/*.c
    - While I am not sure if these *.c files are really needed
      (in the binary rpm), at least executable permissions should
      not be necessary.
      (note that also "devel-file-in-non-devel-package" rpmlint
      appears)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]