https://bugzilla.redhat.com/show_bug.cgi?id=1172525 --- Comment #2 from amigo.elite@xxxxxxxxx --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > It's best not to use temporary places like fpaste for spec files. If you > don't have better place, attach it to this bug. Spec URL: https://github.com/Am1GO/zbackup-rpm/blob/master/zbackup.spec SRPM URL: https://github.com/Am1GO/zbackup-rpm/blob/master/zbackup-1.3-2.fc20.src.rpm Build log: https://kojipkgs.fedoraproject.org//work/tasks/6555/8346555/build.log Build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=8346553 > > You can use mkdir to create a directory. '%{__install} -d' is a bit hard to > read ;) Done. > Also pushd is considered nicer than cd, because the path is printed to the > log. Done. > > From line 17 remove everything except possibly protobuf, not sure about that > one. Dependencies on libraries are added automatically. Done. BTW protobuf doesn't need to be specified too (I've checked deps of rpm). > > Remove lines 38, 44, 45, 48, 49, and 6 too. Done all except 49 because if I remove 49 then rpmbuild will report "unpackaged file" error. Probably you mean to remove "%attr(755,root,root)" macros - it was done. > > Remove line 40, and add -D to Line 42 instead. Done. > > Use %license for LICENSE instead of %doc. Done. > > In line 51, use %{name}.1.* instead of %{name}.1.gz, since the compression > method might change at some point, no need to adjust the spec file for that. Done. > > Can't sponsor you, but otherwise looks OK. I've also added build scenario for tartool (it was supplementary util). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review