https://bugzilla.redhat.com/show_bug.cgi?id=1147351 --- Comment #4 from Scott K Logan <logans@xxxxxxxxxxx> --- Thank you both for your reviews. I'll respond to each of the issues presented: I have requested that upstream add a license file [1]. The CFLAGS have been removed from the spec. I don't see any reason to add a line to the spec file to remove the PKG-INFO. It doesn't get installed on the system, so unless it changes the way the package is built, I see no reason to do anything with it. As for the python-imaging dependency as well as the first two lines of the spec (and also the presence of a "Group:" tag), I do this because I intend to submit this package to el6 and epel7 in addition to Fedora. This spec file will work on all of the following release tags: f19 f20 f21 rawhide el6 epel7. I would rather have extra logic in the spec file than have to maintain multiple copies of it. It makes updating the package significantly easier. Thanks again, --scott [1] https://github.com/modestmaps/modestmaps-js/issues/81 Spec URL: https://cottsay.fedorapeople.org/python-modestmaps/python-modestmaps.spec SRPM URL: https://cottsay.fedorapeople.org/python-modestmaps/python-modestmaps-1.4.6-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review