[Bug 1147351] Review Request: python-modestmaps - Modest Maps python port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1147351

Julien Enselme <jujens@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Julien Enselme <jujens@xxxxxxxxx> ---
> I have requested that upstream add a license file [1].

Thanks.

> I don't see any reason to add a line to the spec file to remove the PKG-INFO. It doesn't get installed on the system, so unless it changes the way the package is built, I see no reason to do anything with it.

As I said you can and you are not compelled to do so.

> As for the python-imaging dependency as well as the first two lines of the spec (and also the presence of a "Group:" tag), I do this because I intend to submit this package to el6 and epel7 in addition to Fedora. This spec file will work on all of the following release tags: f19 f20 f21 rawhide el6 epel7. I would rather have extra logic in the spec file than have to maintain multiple copies of it. It makes updating the package significantly easier.

Point taken.

Approuved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]