https://bugzilla.redhat.com/show_bug.cgi?id=1151464 --- Comment #5 from Christian Dersch <chrisdersch@xxxxxxxxx> --- The package looks nice so far, but you (and upstream) are missing some details on licensing. Output of fedora-review license check below, please check the following files: ballerburg-1.1.0/src/font8x16.h ballerburg-1.1.0/src/sdlgfx.c ballerburg-1.1.0/src/sdlgfx.h The other "unknown" files are ok, there are short notes that they are GPL. (Or they are the matching headers of their GPLed source files). Please clarify the licenses (maybe ask upstream for details), the sdlgfx files are not a problem (zlib license), but I cannot see any info in font8x16.h Greetings Christian GPL (v2 or later) ----------------- ballerburg-1.1.0/src/dlgAlert.c ballerburg-1.1.0/src/psg.c ballerburg-1.1.0/src/psg.h GPL (v3 or later) ----------------- ballerburg-1.1.0/src/baller1.c ballerburg-1.1.0/src/baller1.h ballerburg-1.1.0/src/baller2.c ballerburg-1.1.0/src/baller2.h ballerburg-1.1.0/src/ballergui.c ballerburg-1.1.0/src/cannoneer.c ballerburg-1.1.0/src/market.c ballerburg-1.1.0/src/market.h ballerburg-1.1.0/src/music.c ballerburg-1.1.0/src/music.h ballerburg-1.1.0/src/screen.c ballerburg-1.1.0/src/screen.h ballerburg-1.1.0/src/settings.c Unknown or generated -------------------- ballerburg-1.1.0/cmake/config-cmake.h ballerburg-1.1.0/src/ballergui.h ballerburg-1.1.0/src/font8x16.h ballerburg-1.1.0/src/i18n.h ballerburg-1.1.0/src/paths.c ballerburg-1.1.0/src/paths.h ballerburg-1.1.0/src/sdlgui.c ballerburg-1.1.0/src/sdlgui.h ballerburg-1.1.0/src/settings.h zlib/libpng ----------- ballerburg-1.1.0/src/sdlgfx.c ballerburg-1.1.0/src/sdlgfx.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review