[Bug 1151759] Review Request: tclbsd - Interfacing to various BSD UNIX system calls and routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1151759

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orion@xxxxxxxxxxxxx



--- Comment #6 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
Some comments:

- Drop %defattr()
- No need to mark man pages as %doc
- Debug is not generated because library is installed with mode 644 instead of
755.  You can fix in %install or with:

diff -up tclbsd-1.6/Makefile.in.lib tclbsd-1.6/Makefile.in
--- tclbsd-1.6/Makefile.in.lib  2014-10-06 19:11:16.000000000 -0600
+++ tclbsd-1.6/Makefile.in      2014-10-12 14:57:32.895712714 -0600
@@ -91,7 +91,7 @@ INSTALL_DATA_DIR = @INSTALL_DATA_DIR@
 INSTALL_DATA   = @INSTALL_DATA@
 INSTALL_PROGRAM        = @INSTALL_PROGRAM@
 INSTALL_SCRIPT = @INSTALL_SCRIPT@
-INSTALL_LIBRARY        = @INSTALL_LIBRARY@
+INSTALL_LIBRARY        = @INSTALL_PROGRAM@

 PACKAGE_NAME   = @PACKAGE_NAME@
 PACKAGE_VERSION        = @PACKAGE_VERSION@

- No need for rm -rf $RPM_BUILD_ROOT in %install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]