[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1039315



--- Comment #60 from MartinKG <mgansser@xxxxxxxx> ---
(In reply to Christopher Meng from comment #59)

> -------------------------
> 1. Filter out libnuvolaplayerprivate.so.

(Michael Schwendt from comment #39)
The libnuvolaplayerprivate.so is a private runtime library required
by the nuvolaplayer binary.

error message when exluding .so file:
$ nuvolaplayer
/usr/lib64/nuvolaplayer/nuvolaplayer: error while loading shared libraries:
libnuvolaplayerprivate.so: cannot open shared object file: No such file or
directory


> 
> 2. Include license texts as well, notably those you've written in License
> tag.

done

> 3. Why does this package invoke ldconfig?

removed

> 
> 4. Other trifles are in review texts above.
> 
> 5. Consider asking upstream to make an option for test instead of bundling
> in the build.
can i do


Spec URL:
https://www.dropbox.com/s/6nj8ol466f5gxe3/nuvolaplayer-2.4.2-4.fc20.src.rpm?dl=0
SRPM URL: https://www.dropbox.com/s/ua1hj7yv1mll9j3/nuvolaplayer.spec?dl=0


%changelog
* Wed Sep 03 2014 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 2.4.2-4
- added license files described in license tag
- removed ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]