https://bugzilla.redhat.com/show_bug.cgi?id=1135168 --- Comment #6 from David Dick <ddick@xxxxxxxx> --- license is correct. package builds successfully in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7512906 epel6 builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7512933 rpmlint is clean TODO: If you sort your BuildRequires, it is a lot easier for reviewers. FIX: Missing BuildRequires. All modules loaded while building and testing this module should be included. They are listed below; BR: perl(Carp) BR: perl(Encode) BR: perl(strict) BR: perl(Test::More) MUST FIX: The test suite must be enabled. TODO: I would recommend you use the Module::Build option for building this module. The author provides a Makefile.PL, but it is just a wrapper around Module::Build. MUST FIX: "BuildRequires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))" is incorrect. This is a Run Time requirement, use a "Requires" instead of a "BuildRequires" TODO: PERL_INSTALL_ROOT should be changed to DESTDIR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review