https://bugzilla.redhat.com/show_bug.cgi?id=1039315 --- Comment #59 from Christopher Meng <i@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== Generic: [x ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ !]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "LGPL (v2.1 or later)", "LGPL (v3 or later)", "Unknown or generated". 101 files have unknown license. Detailed output of licensecheck: BSD (2 clause) -------------- nuvolaplayer-2.4.2/src/diorite/configuration.vala nuvolaplayer-2.4.2/src/diorite/connection.vala nuvolaplayer-2.4.2/src/diorite/diorite-infobar.vala nuvolaplayer-2.4.2/src/diorite/diorite-simpledocbuffer.vala nuvolaplayer-2.4.2/src/diorite/diorite-simpledocview.vala nuvolaplayer-2.4.2/src/diorite/diorite-wrappedlabel.vala nuvolaplayer-2.4.2/src/diorite/f-actions.vala nuvolaplayer-2.4.2/src/diorite/f-application.vala nuvolaplayer-2.4.2/src/diorite/keybindings.vala nuvolaplayer-2.4.2/src/diorite/logger.vala nuvolaplayer-2.4.2/src/diorite/storage.vala nuvolaplayer-2.4.2/src/diorite/system.vala nuvolaplayer-2.4.2/src/diorite/tests.vala nuvolaplayer-2.4.2/src/diorite/tools.vala nuvolaplayer-2.4.2/src/diorite/uiparser.vala nuvolaplayer-2.4.2/src/diorite/widgets.vala nuvolaplayer-2.4.2/src/nuvola/core/core.vala nuvolaplayer-2.4.2/src/nuvola/core/extension.vala nuvolaplayer-2.4.2/src/nuvola/core/extensionsmanager.vala nuvolaplayer-2.4.2/src/nuvola/core/info.vala nuvolaplayer-2.4.2/src/nuvola/core/jsapi.vala nuvolaplayer-2.4.2/src/nuvola/core/jstools.vala nuvolaplayer-2.4.2/src/nuvola/core/nuvola-formatsupport.vala nuvolaplayer-2.4.2/src/nuvola/core/nuvola-framebridge.vala nuvolaplayer-2.4.2/src/nuvola/core/nuvola-updatesservice.vala nuvolaplayer-2.4.2/src/nuvola/core/objectcontainer.vala nuvolaplayer-2.4.2/src/nuvola/core/player.vala nuvolaplayer-2.4.2/src/nuvola/core/service.vala nuvolaplayer-2.4.2/src/nuvola/core/servicesmanager.vala nuvolaplayer-2.4.2/src/nuvola/core/serviceupdates.vala nuvolaplayer-2.4.2/src/nuvola/core/settings.vala nuvolaplayer-2.4.2/src/nuvola/core/webbackend.vala nuvolaplayer-2.4.2/src/nuvola/extensions/developerbar.vala nuvolaplayer-2.4.2/src/nuvola/extensions/dock_manager.vala nuvolaplayer-2.4.2/src/nuvola/extensions/lastfm.vala nuvolaplayer-2.4.2/src/nuvola/extensions/lyrics.vala nuvolaplayer-2.4.2/src/nuvola/extensions/media_keys.vala nuvolaplayer-2.4.2/src/nuvola/extensions/mpris.vala nuvolaplayer-2.4.2/src/nuvola/extensions/notifications.vala nuvolaplayer-2.4.2/src/nuvola/extensions/sample.vala nuvolaplayer-2.4.2/src/nuvola/extensions/trayicon.vala nuvolaplayer-2.4.2/src/nuvola/extensions/unity_quick_list.vala nuvolaplayer-2.4.2/src/nuvola/gui/aboutdialog.vala nuvolaplayer-2.4.2/src/nuvola/gui/downloadsdialog.vala nuvolaplayer-2.4.2/src/nuvola/gui/extensionsmanagerview.vala nuvolaplayer-2.4.2/src/nuvola/gui/inspectorwindow.vala nuvolaplayer-2.4.2/src/nuvola/gui/mainwebview.vala nuvolaplayer-2.4.2/src/nuvola/gui/mainwindow.vala nuvolaplayer-2.4.2/src/nuvola/gui/nuvola-formatsupportdialog.vala nuvolaplayer-2.4.2/src/nuvola/gui/nuvola-welcomeoverlay.vala nuvolaplayer-2.4.2/src/nuvola/gui/popupwebview.vala nuvolaplayer-2.4.2/src/nuvola/gui/preferences.vala nuvolaplayer-2.4.2/src/nuvola/gui/serviceselectordialog.vala nuvolaplayer-2.4.2/src/nuvola/gui/servicesmanagerview.vala nuvolaplayer-2.4.2/src/nuvola/gui/serviceupdatesdialog.vala nuvolaplayer-2.4.2/src/nuvola/gui/staticwebview.vala nuvolaplayer-2.4.2/src/nuvola/gui/webview.vala nuvolaplayer-2.4.2/src/nuvolaplayer-client.vala nuvolaplayer-2.4.2/src/nuvolaplayer.vala nuvolaplayer-2.4.2/src/webkitframe/webkitframe.vala nuvolaplayer-2.4.2/tests/interactive/diorite-simpledocviewtest.vala nuvolaplayer-2.4.2/tests/interactive/nuvola-notificationstest.vala nuvolaplayer-2.4.2/tests/main/diorite-simpledocbuffertest.vala nuvolaplayer-2.4.2/tests/main/nuvola-lyricstest.vala nuvolaplayer-2.4.2/tools/create-copyright-file.py nuvolaplayer-2.4.2/tools/make_service_package.sh nuvolaplayer-2.4.2/tools/slow_download_server.py nuvolaplayer-2.4.2/waf_nuvolaextras.py LGPL (v2.1 or later) -------------------- nuvolaplayer-2.4.2/external/fsotest/assert.vala nuvolaplayer-2.4.2/external/fsotest/signalwaiter.vala nuvolaplayer-2.4.2/external/fsotest/testcase.vala LGPL (v3 or later) ------------------ nuvolaplayer-2.4.2/external/fsotest/asynchelpers.vala Unknown or generated -------------------- nuvolaplayer-2.4.2/glibtest.py nuvolaplayer-2.4.2/setup_env.sh nuvolaplayer-2.4.2/src/diorite/keybindings.h nuvolaplayer-2.4.2/src/nuvola/core/config.vala nuvolaplayer-2.4.2/src/nuvola/extensions/debugging.vala nuvolaplayer-2.4.2/tests/common/common.vala nuvolaplayer-2.4.2/tests/interactive/tests-interactive.vala nuvolaplayer-2.4.2/tests/main/nuvola-jsapitest.vala nuvolaplayer-2.4.2/tests/main/nuvola-servicesmanagertest.vala nuvolaplayer-2.4.2/tests/main/tests-main.vala nuvolaplayer-2.4.2/tests/mock/mockaplication.vala nuvolaplayer-2.4.2/tests/mock/mockplayer.vala nuvolaplayer-2.4.2/tests/uidemo/gui-formatsupportdialogdemo.vala nuvolaplayer-2.4.2/tests/uidemo/gui-infobardemo.vala nuvolaplayer-2.4.2/tests/uidemo/gui-main.vala nuvolaplayer-2.4.2/tests/uidemo/gui-mainwindow-test.vala nuvolaplayer-2.4.2/tests/uidemo/gui-wrappedlabeldemo.vala nuvolaplayer-2.4.2/tools/copyrightdata.py nuvolaplayer-2.4.2/tools/flag-test.sh nuvolaplayer-2.4.2/tools/gettext_extract.sh nuvolaplayer-2.4.2/tools/import_translations.sh nuvolaplayer-2.4.2/tools/memtest.sh nuvolaplayer-2.4.2/tools/nuvoladoc.sh nuvolaplayer-2.4.2/tools/package_db.py nuvolaplayer-2.4.2/tools/service-package/install_service.sh nuvolaplayer-2.4.2/tools/todo_list.sh nuvolaplayer-2.4.2/waflib/Build.py nuvolaplayer-2.4.2/waflib/ConfigSet.py nuvolaplayer-2.4.2/waflib/Configure.py nuvolaplayer-2.4.2/waflib/Context.py nuvolaplayer-2.4.2/waflib/Errors.py nuvolaplayer-2.4.2/waflib/Logs.py nuvolaplayer-2.4.2/waflib/Node.py nuvolaplayer-2.4.2/waflib/Options.py nuvolaplayer-2.4.2/waflib/Runner.py nuvolaplayer-2.4.2/waflib/Scripting.py nuvolaplayer-2.4.2/waflib/Task.py nuvolaplayer-2.4.2/waflib/TaskGen.py nuvolaplayer-2.4.2/waflib/Tools/__init__.py nuvolaplayer-2.4.2/waflib/Tools/ar.py nuvolaplayer-2.4.2/waflib/Tools/asm.py nuvolaplayer-2.4.2/waflib/Tools/bison.py nuvolaplayer-2.4.2/waflib/Tools/c.py nuvolaplayer-2.4.2/waflib/Tools/c_aliases.py nuvolaplayer-2.4.2/waflib/Tools/c_config.py nuvolaplayer-2.4.2/waflib/Tools/c_osx.py nuvolaplayer-2.4.2/waflib/Tools/c_preproc.py nuvolaplayer-2.4.2/waflib/Tools/c_tests.py nuvolaplayer-2.4.2/waflib/Tools/ccroot.py nuvolaplayer-2.4.2/waflib/Tools/compiler_c.py nuvolaplayer-2.4.2/waflib/Tools/compiler_cxx.py nuvolaplayer-2.4.2/waflib/Tools/compiler_d.py nuvolaplayer-2.4.2/waflib/Tools/compiler_fc.py nuvolaplayer-2.4.2/waflib/Tools/cs.py nuvolaplayer-2.4.2/waflib/Tools/cxx.py nuvolaplayer-2.4.2/waflib/Tools/d.py nuvolaplayer-2.4.2/waflib/Tools/d_config.py nuvolaplayer-2.4.2/waflib/Tools/d_scan.py nuvolaplayer-2.4.2/waflib/Tools/dbus.py nuvolaplayer-2.4.2/waflib/Tools/dmd.py nuvolaplayer-2.4.2/waflib/Tools/errcheck.py nuvolaplayer-2.4.2/waflib/Tools/fc.py nuvolaplayer-2.4.2/waflib/Tools/fc_config.py nuvolaplayer-2.4.2/waflib/Tools/fc_scan.py nuvolaplayer-2.4.2/waflib/Tools/flex.py nuvolaplayer-2.4.2/waflib/Tools/g95.py nuvolaplayer-2.4.2/waflib/Tools/gas.py nuvolaplayer-2.4.2/waflib/Tools/gcc.py nuvolaplayer-2.4.2/waflib/Tools/gdc.py nuvolaplayer-2.4.2/waflib/Tools/gfortran.py nuvolaplayer-2.4.2/waflib/Tools/glib2.py nuvolaplayer-2.4.2/waflib/Tools/gnu_dirs.py nuvolaplayer-2.4.2/waflib/Tools/gxx.py nuvolaplayer-2.4.2/waflib/Tools/icc.py nuvolaplayer-2.4.2/waflib/Tools/icpc.py nuvolaplayer-2.4.2/waflib/Tools/ifort.py nuvolaplayer-2.4.2/waflib/Tools/intltool.py nuvolaplayer-2.4.2/waflib/Tools/irixcc.py nuvolaplayer-2.4.2/waflib/Tools/javaw.py nuvolaplayer-2.4.2/waflib/Tools/kde4.py nuvolaplayer-2.4.2/waflib/Tools/ldc2.py nuvolaplayer-2.4.2/waflib/Tools/lua.py nuvolaplayer-2.4.2/waflib/Tools/msvc.py nuvolaplayer-2.4.2/waflib/Tools/nasm.py nuvolaplayer-2.4.2/waflib/Tools/perl.py nuvolaplayer-2.4.2/waflib/Tools/python.py nuvolaplayer-2.4.2/waflib/Tools/qt4.py nuvolaplayer-2.4.2/waflib/Tools/ruby.py nuvolaplayer-2.4.2/waflib/Tools/suncc.py nuvolaplayer-2.4.2/waflib/Tools/suncxx.py nuvolaplayer-2.4.2/waflib/Tools/tex.py nuvolaplayer-2.4.2/waflib/Tools/vala.py nuvolaplayer-2.4.2/waflib/Tools/waf_unit_test.py nuvolaplayer-2.4.2/waflib/Tools/winres.py nuvolaplayer-2.4.2/waflib/Tools/xlc.py nuvolaplayer-2.4.2/waflib/Tools/xlcxx.py nuvolaplayer-2.4.2/waflib/Utils.py nuvolaplayer-2.4.2/waflib/__init__.py nuvolaplayer-2.4.2/waflib/ansiterm.py nuvolaplayer-2.4.2/waflib/extras/__init__.py nuvolaplayer-2.4.2/waflib/fixpy2.py [x ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ !]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/nuvolaplayer [ !]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec/nuvolaplayer [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in nuvolaplayer [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nuvolaplayer-2.4.2-3.fc22.x86_64.rpm nuvolaplayer-2.4.2-3.fc22.src.rpm nuvolaplayer.x86_64: W: spelling-error %description -l en_US Nuvola -> Nolan nuvolaplayer.x86_64: W: no-manual-page-for-binary nuvolaplayer nuvolaplayer.x86_64: W: no-manual-page-for-binary nuvolaplayer-client nuvolaplayer.x86_64: W: desktopfile-without-binary /usr/share/applications/nuvolaplayer.desktop nuvolaplayer nuvolaplayer.src: W: spelling-error %description -l en_US Nuvola -> Nolan 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nuvolaplayer nuvolaplayer.x86_64: W: spelling-error %description -l en_US Nuvola -> Nolan nuvolaplayer.x86_64: W: no-manual-page-for-binary nuvolaplayer nuvolaplayer.x86_64: W: no-manual-page-for-binary nuvolaplayer-client 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nuvolaplayer (rpmlib, GLIBC filtered): /bin/sh control-center-filesystem libX11.so.6()(64bit) libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjavascriptcoregtk-3.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libnotify.so.4()(64bit) libnuvolaplayerprivate.so()(64bit) libpango-1.0.so.0()(64bit) libpthread.so.0()(64bit) libsoup-2.4.so.1()(64bit) libwebkitgtk-3.0.so.0()(64bit) rtld(GNU_HASH) tsocks Provides -------- nuvolaplayer: application() application(nuvolaplayer.desktop) libnuvolaplayerprivate.so()(64bit) nuvolaplayer nuvolaplayer(x86-64) Unversioned so-files -------------------- nuvolaplayer: /usr/lib64/libnuvolaplayerprivate.so nuvolaplayer: /usr/lib64/nuvolaplayer/libnuvolaplayerprivate.so Source checksums ---------------- https://launchpad.net/nuvola-player/2.4.x/2.4.2/+download/nuvolaplayer-2.4.2.tar.gz : CHECKSUM(SHA256) this package : f0bba6869ee86a6387fd7b556c2b7816f7e2a15d5524a1daab68095f4a709db3 CHECKSUM(SHA256) upstream package : f0bba6869ee86a6387fd7b556c2b7816f7e2a15d5524a1daab68095f4a709db3 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -rvn nuvolaplayer-2.4.2-3.fc20.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------- 1. Filter out libnuvolaplayerprivate.so. 2. Include license texts as well, notably those you've written in License tag. 3. Why does this package invoke ldconfig? 4. Other trifles are in review texts above. 5. Consider asking upstream to make an option for test instead of bundling in the build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review