https://bugzilla.redhat.com/show_bug.cgi?id=1124070 --- Comment #4 from Ryan Brown <rybrown@xxxxxxxxxx> --- Parag, Thank you for your review, I've responded inline. 1) spec file name should not contain any version or release. The spec file name only contains a version so I can make multiple revisions available from my web site, the actual spec file on my local machine does not have a version in its filename. 2) If you are not planning to add this package to EPEL6 then remove following from spec a) Group tag is now optional and can be removed. Done b) "rm -rf %{buildroot}" is not needed anymore as its done automatically by rpmbuild Done c) similarly %clean section is also not needed anymore Done 3) %prep should contain only %setup -q For my case %setup -cq is necessary because the upstream tarball extracts files directly into current directory instead of extracting to a folder 4) Though there is no compilation or building of binary files happening, you can include empty %build to let rpmlint happy Done 5) Don't add extra empty spaces in the spec file like one you have line 59 Removed 6) I think you can if wanted keep the priority of fontconfig file to 69. Generally 60-69 numbers are used for "generic aliases, map generic->family" and you have the same fontconfig rule. Done New SRPM: http://rsb.io/pkg/hermit/pcaro-hermit-fonts-1.21-3.fc20.src.rpm New specfile: http://rsb.io/pkg/hermit/pcaro-hermit-fonts-1.21-3.spec Thanks very much for your feedback, let me know what you think of the changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review